Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: added caching to XBlockSkillsViewSet list endpoint #208

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

hamza-56
Copy link
Contributor

@hamza-56 hamza-56 commented Oct 2, 2024

PROD 4135

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

@hamza-56 hamza-56 requested review from muhammad-ammar, AfaqShuaib09, Ali-D-Akbar and zawan-ila and removed request for muhammad-ammar October 2, 2024 12:06
@hamza-56 hamza-56 self-assigned this Oct 2, 2024
@hamza-56 hamza-56 force-pushed the hamza/PROD-4135 branch 2 times, most recently from 9430a9a to 0fc496c Compare October 2, 2024 12:17
Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

taxonomy/api/v1/views.py Outdated Show resolved Hide resolved
@hamza-56 hamza-56 force-pushed the hamza/PROD-4135 branch 2 times, most recently from 436a650 to ef65d4c Compare October 3, 2024 09:36
Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the necessary details along with the ticket link in the PR description? Also, try to resolve the coverage issues before merging.
Other than that, everything looks good to me 👍.


cached_response = TieredCache.get_cached_response(cache_key)
if cached_response.is_found:
return Response(cached_response.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test for this.

@DawoudSheraz DawoudSheraz merged commit f0d956a into openedx:master Oct 9, 2024
10 checks passed
@hamza-56 hamza-56 deleted the hamza/PROD-4135 branch October 9, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants